ref(sdk/go): Refactor the Redis Go SDK to be more idiomatic #1844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vdice
reviewed
Oct 9, 2023
There was a problem hiding this comment.
A reminder to track or line up updates to examples/docs in https://github.com/fermyon/developer on/around the 2.0 release.
Not sure if we have opinionated Go programmers/users that might be a better sign-off on this PR, but the changes look reasonable to me!
adamreese
force-pushed
the
feat/sdk-go-redis-v2
branch
from
aee1fd9
to
006792f
Compare
adamreese
force-pushed
the
feat/sdk-go-redis-v2
branch
2 times, most recently
from
bb5f39c
to
9b57763
Compare
adamreese
commented
Oct 26, 2023
| // should work with any Redis command. | ||
| // | ||
| // Arguments must be string, []byte, int, int64, or int32. | ||
| func (c *Client) Execute(command string, arguments ...any) ([]*Result, error) { |
There was a problem hiding this comment.
I would love some opinions on using an any rather than a typed argument. I don't know how I feel about it.
There was a problem hiding this comment.
Its pretty standard for better or worse 🤷
There was a problem hiding this comment.
I would probably have this return an error if an unsupported type is passed in though.
adamreese
force-pushed
the
feat/sdk-go-redis-v2
branch
3 times, most recently
from
d2322cb
to
39b0699
Compare
- Introduces a client struct responsible for handling the connection - Refactor the `Execute()` arguments Signed-off-by: Adam Reese <[email protected]>
adamreese
force-pushed
the
feat/sdk-go-redis-v2
branch
from
39b0699
to
ae26b6e
Compare
lann
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Execute()arguments